Update utils.py to forward size parameter in RawPcapnpReader#4721
Merged
Conversation
I found this little flaw when reading packages from a pcap that was captured on a different device. This fixed the issue of raw data being truncated. If there is a good reason to ignore the size in here lmk
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4721 +/- ##
==========================================
- Coverage 82.12% 78.56% -3.56%
==========================================
Files 361 336 -25
Lines 87079 81872 -5207
==========================================
- Hits 71510 64323 -7187
- Misses 15569 17549 +1980 🚀 New features to boost your workflow:
|
Contributor
|
Thanks for the PR |
gpotter2
approved these changes
May 29, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I found this little flaw when reading packages from a pcap that was captured on a different device. This fixed the issue of raw data being truncated. If there is a good reason to ignore the size in here lmk
Checklist:
cd test && ./run_testsortox)RawPcapNgReader will now forward size to lower level parsing, allowing for configuration to trickle down
Default state is not touched.
Unit tests should ideally not be effected by this
There should be no impact in other parts of the library